-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CPP20][DQM] Replace some enums with constexpr ints #44515
[CPP20][DQM] Replace some enums with constexpr ints #44515
Conversation
cms-bot internal usage |
please test for CMSSW14_1_CPP20_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44515/39639
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@jfernan2, @syuvivida, @francescobrivio, @tjavaid, @mandrenguyen, @saumyaphor4252, @nothingface0, @perrotta, @cmsbuild, @civanch, @mdhildreth, @consuegs, @rvenditti, @antoniovagnerini can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test for CMSSW_14_1_CPP20_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44515/39644
|
Pull request #44515 was updated. @tjavaid, @perrotta, @antoniovagnerini, @cmsbuild, @francescobrivio, @nothingface0, @syuvivida, @consuegs, @mdhildreth, @mandrenguyen, @jfernan2, @saumyaphor4252, @civanch, @rvenditti can you please check and sign again. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44515/39742
|
Pull request #44515 was updated. @antoniovagnerini, @syuvivida, @nothingface0, @civanch, @mdhildreth, @tjavaid, @rvenditti can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f57598/38513/summary.html Comparison SummarySummary:
|
+1 |
@cms-sw/dqm-l2 gentle ping |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Replace some enums with constexpr ints to avoid deprecated enum arithmetics. Replaces #44487 following @makortel's suggestion.
PR validation:
Bot tests